Skills

Quality

Post-cook quality gate.

Install

npx skills add poteto/noodle --skill quality -g -a claude-code -y
Repository
poteto/noodle577
Category
Engineering
Updated
8mo ago
License
MIT
Context cost
Lightabout 661 tokens
Runs scripts
No, instructions only

What it does

Post-cook quality gate. Reviews completed cook work for correctness, scope discipline, and principle compliance. Emits stage_message events with findings. Triggers after execute stages, on '/quality', 'review this', 'check the work', 'assess quality'.

Quality

Review completed cook work. Emit a stage_message event with your assessment. See references/stage-message-schema.md for the event schema.

Operate fully autonomously. Never ask the user.

Step 0 -- Load Principles

Read brain/principles.md and follow every [[wikilink]]. These govern the review. Do NOT skip this.

Assessment Pipeline

Run in order. Stop early and reject on any high-severity finding.

1. Scope Check

  • Read the plan phase the cook was assigned (from the cook's initial prompt or mise context).
  • Run git diff --stat and git log --oneline for the cook's commits.
  • Flag files changed outside the plan phase's stated scope as scope violations.

2. Code Quality

  • go vet ./... and go test ./... must pass.
  • Run sh scripts/lint-arch.sh if it exists.
  • Check error handling follows project conventions (failure-state messages, not expectation messages).

3. Principle Compliance

  • For each changed file, check against loaded principles.
  • Common violations: bolted-on changes instead of redesign (redesign-from-first-principles), missing verification (prove-it-works), unnecessarily added complexity (subtract-before-you-add).

4. Test Evidence

  • New behavior must have new tests.
  • Tests must assert outcomes, not implementation details.
  • Check coverage of edge cases mentioned in the plan phase.

5. Runtime Verification

  • If the plan phase specifies runtime checks, verify they were performed.
  • "It compiles" is not verification.

Verdict

Emit a stage_message event with your assessment:

noodle event emit --session $NOODLE_SESSION_ID stage_message --payload '<json>'

Accept: Emit with blocking: false. The pipeline continues and the scheduler sees the green light.

{ "message": "All checks pass. Tests green, scope clean.", "blocking": false }

Reject: Emit with blocking: true (or omit blocking). The scheduler reads findings and decides (retry, add oops stage, or abort).

Read the whole SKILL.md on GitHub

More in Engineering