
Tuist Swift Review
Project-specific pull request review rules for the tuist/tuist Swift codebases.
Install
npx skills add tuist/tuist --skill tuist-swift-review -g -a claude-code -y- Repository
- tuist/tuist5.9k
- Category
- Testing
- Updated
- 3d ago
- License
- See repository
- Context cost
- Lightabout 1,113 tokens
- Runs scripts
- No, instructions only
What it does
Project-specific pull request review rules for the tuist/tuist Swift codebases. Focuses on the things only this repo knows, including preferring value types, the testing framework choice, and migration of XCTest to Swift Testing.
Tuist Swift Review
This skill is intentionally narrow. Generic Swift style, formatting, naming, and lint hygiene are already covered by SwiftFormat and SwiftLint in continuous integration. Do not flag those. Focus on the rules below.
For each finding, cite path:line and quote the relevant snippet.
1. Prefer structs over classes
Default to struct for new types. Reach for class only when reference
semantics, identity, inheritance, or deinit are actually required.
Flag
- A new
classdeclaration that has no stored mutable identity, no inheritance, nodeinit, and is not bridged to an Objective-C / Cocoa API. Recommend converting it to astruct. Severity: medium.
Do not flag
- Existing classes left unchanged by the diff.
- Classes that subclass a framework type (
NSObject,XCTestCase,Operation, etc.) or conform to a protocol that requires reference semantics. - Types that genuinely need reference identity (caches, long-lived coordinators, actors-with-state-shared-by-reference).
final classdeclarations whoseSendableconformance is backed by a storedSynchronization.Mutex<State>(or another~Copyablesynchronization primitive).Mutexcannot be a stored property of aCopyablestruct, the compiler emitsstored property '...' of 'Copyable'-conforming struct '...' has non-Copyable type 'Mutex<...>', and a~Copyablestruct cannot be captured by a@Sendableclosure. Afinal classwith theMutexandSendableconformance is the correct expression of this pattern.
2. Avoid @unchecked Sendable
@unchecked Sendable opts out of the compiler's concurrency safety
checks and shifts the burden of correctness onto every reader. Prefer
proper synchronization primitives that the compiler can verify.


